GH-139946: Colorize error and warning messages in argparse #140695
Conversation
savannahostrowski
requested review from
AA-Turner and
erlend-aasland
as code owners
|
@hugovk would love to get your thoughts here as well. Not sure if not colorizing error/warning keywords was an intentional choice when color was added, but I agree with the user in the issue; the current UX feels a little inconsistent. That said, I could go either way on this. I have removed the backport label, since this is not eligible for backport (it's likely to be a breaking change for some folks). |
|
It was intentional only as far as I didn't have time to include it for 3.14 and was hoping to do a followup for 3.15, so thank you! PR looks good. Bikeshedding the colour a little bit, what do you think doing something similar to traceback? Either same colours (bold magenta for error name, bold for error message), or same scheme (one colour for error name, another for message). 
And something also for the warnings? |
|
Oh good call! Updated! |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
2 participants
This PR fixes a visual inconsistency in the way that argparse displays error or warning messages with color enabled; the usage line and options are colorized, but the "error:" and "warning:" keywords remain as plain text. This change extends the existing colorization to be consistent across all outputs.
For example:
Before
After
